Skip to content

Preserve signed ellipse axes in extent conversion#4284

Closed
FlorianPfaff wants to merge 17 commits into
mainfrom
agent/preserve-signed-ellipse-axes
Closed

Preserve signed ellipse axes in extent conversion#4284
FlorianPfaff wants to merge 17 commits into
mainfrom
agent/preserve-signed-ellipse-axes

Conversation

@FlorianPfaff

Copy link
Copy Markdown
Owner

Summary

  • convert ellipse semi-axis coordinates to magnitudes before constructing the extent matrix
  • preserve the physical extent for equivalent negative-axis representations
  • add focused regression coverage for both the direct and shape-state conversion paths

Bug

ellipse_extent_matrix() clipped negative semi-axis coordinates to zero before squaring them. Elsewhere in the ellipse geometry API, axis signs are treated as representation choices and canonicalized with an absolute value. As a result, a valid signed shape state such as [theta, -3, -1] produced a collapsed extent matrix instead of the same extent as [theta, 3, 1].

Fix

Use the active backend's absolute-value operation before squaring the semi-axis coordinates. This keeps NumPy, PyTorch, and JAX backend behavior aligned with the module's existing canonicalization semantics.

Validation

  • reproduced the failure on the main implementation with NumPy-backed module stubs
  • verified sign invariance for each single-axis and double-axis sign flip after the change
  • python -m py_compile src/pyrecest/tracking/ellipse_geometry.py tests/tracking/test_ellipse_extent_negative_axes.py

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ COPYPASTE jscpd yes no no 27.01s
✅ JSON prettier 7 0 0 0 1.14s
✅ JSON v8r 7 0 0 4.66s
✅ MARKDOWN markdownlint 68 0 0 0 1.92s
✅ MARKDOWN markdown-table-formatter 68 0 0 0 0.61s
✅ PYTHON black 1490 182 0 0 101.73s
✅ PYTHON isort 1490 328 0 0 2.72s
✅ REPOSITORY betterleaks yes no no 2.69s
✅ REPOSITORY checkov yes no no 59.27s
✅ REPOSITORY gitleaks yes no no 15.63s
✅ REPOSITORY git_diff yes no no 0.31s
✅ REPOSITORY secretlint yes no no 72.78s
✅ REPOSITORY syft yes no no 6.79s
✅ REPOSITORY trivy-sbom yes no no 7.07s
✅ REPOSITORY trufflehog yes no no 34.01s
✅ YAML prettier 11 0 0 0 0.79s
✅ YAML v8r 11 0 0 11.09s
✅ YAML yamllint 11 0 0 0.64s

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.6.0 --custom-flavor-setup --custom-flavor-linters PYTHON_BLACK,PYTHON_ISORT,COPYPASTE_JSCPD,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_BETTERLEAKS,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

@FlorianPfaff FlorianPfaff force-pushed the agent/preserve-signed-ellipse-axes branch from 7b1fbe2 to bd4cabe Compare July 13, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant