docs: record why this repo stays public and add codeowners - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR does two things:
.gitleaks.tomltakes effect across the org the moment it merges, that the fetch of it is deliberately fail-closed and what that costs, and that a repo-local.gitleaks.tomlmustextendthe org one..github/CODEOWNERS: adds an owner for/.gitleaks.tomland/.github/workflows/..gitleaks.tomlitself is unchanged.Proof
The fetch this README describes is at
.github/workflows/gitleaks.yml("Fetch the org allowlist":curl -fsSL .../main/.gitleaks.toml, with no fallback).Not in this PR
CODEOWNERS only routes review requests. Making code-owner review required on
mainis a ruleset change. It needs a bypass decision, because every human in the org is an org owner, so it is left for that decision.