feat(workflows): add a reusable commit-email check for public repos - #34
Open
CameronBrooks11 wants to merge 1 commit into
Open
CameronBrooks11 wants to merge 1 commit into
CameronBrooks11 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
.github/workflows/commit-email.yml, a reusable check for public repos. It fails when a commit that a PR or push adds is authored or committed with an address outside@flowmatrixai.com. It allows:[bot]@users.noreply.github.comand Copilotnoreply@github.comas the committer of a web-UI mergeIt checks only the commits being added, never existing history, so adopting it requires no rewrite.
tests/commit-email.test.shextracts the workflow'srun:block and runs it against throwaway git repos, so the tested code is the shipped code.Part of the commit-identity standard (eng-governance#132). This is new code for review.
Reach: callers pin this repo's workflows by digest, so adding a file here changes nothing for anyone. A public repo adopts the check by adding a caller workflow, as shown in the header comment.
Proof
Mutation sweep. Each mutation was hash-checked to confirm it applied, and each is caught:
shellcheckis clean on the extractedrun:block and on the test.The bot allowlist was taken from this repo's own history:
renovate[bot](author) /noreply@github.com(committer), andCopilot@users.noreply.github.com.