Repository navigation
setImageSrc(String) keeps the cropped image of the previous source #38
Description
Describe the bug
After changing the image with setImageSrc(String), getCroppedImageDataUri() (and getCroppedImageBase64()) still return the value from the previous image until the user crops the new one.
Expected behavior
Changing the image source should reset the cropped image, consistently with the constructor: ImageCrop(String) initializes it to the image source itself.
Minimal reproducible example
ImageCrop imageCrop = new ImageCrop("images/first.png");
imageCrop.setImageSrc("images/second.png");
imageCrop.getCroppedImageDataUri(); // returns "images/first.png"Add-on Version
1.3.0
Vaadin Version
24.8.4
Additional information
Found while reviewing #37, where the equivalent case for the new setImageSrc(DownloadHandler) was fixed.
Activity
paodb commentedon Oct 14, 2026
Related, also pre-existing (found by @javier-godoy while reviewing #37): the String constructor stores the image URL in
croppedImageDataUri, sonew ImageCrop("images/empty-plant.png").getCroppedImageBase64()tries to Base64-decode a URL and throwsIllegalArgumentException.ImageCrop(DownloadHandler)returnsnullin the same situation, so the two constructors disagree.fix!: reset cropped image when the image source changes
fix!: reset cropped image when the image source changes