FEATURE: Improve metrics and modernise plugin - #27
Conversation
There was a problem hiding this comment.
i understand the idea of this file but im not sure how we should could keep it up to date. There are things mentioned like PHP class and mehod names which are purely an implementation detail and can change anytime. These details are imo not relevant to the user. And also not understood without further context.
There was a problem hiding this comment.
I would rather recommend adding a shared interface and adding documentation there or something maybe via php attribute
There was a problem hiding this comment.
People rarely look at the code for documentation.
I want a doc page for each feature and explain their use cases. So this is the (auto-generated) start of that. It will require screenshots etc. to give more value.
| /** | ||
| * Bootstrap file that locates the Composer autoloader regardless of where | ||
| * the package is installed (monorepo DistributionPackages/, Neos Packages/Plugins/, etc.). | ||
| */ | ||
| $possiblePaths = [ | ||
| __DIR__ . '/../../Packages/Libraries/autoload.php', | ||
| __DIR__ . '/../../Libraries/autoload.php', | ||
| __DIR__ . '/../../../Packages/Libraries/autoload.php', | ||
| ]; |
There was a problem hiding this comment.
interesting idea ... but isnt it already limited because the composer script only looks up phpstan which must be in $PATH and its only in path if this package itself is the root which it never actually is if it should work in production with Flow?
"require-dev": {
"phpstan/phpstan": "^1.10"
There was a problem hiding this comment.
Huh? Composer finds all binaries from all dependencies if they marked them. This path workaround is just so that phpstan finds all relevant classes no matter where and how the package is installed with the same config.
The performance hit in rendering can be up to 20% depending on the complexity of a page. So this should be used when needed and further optimised in the future if possible.
New features:
Improvements: