fix(security): replace excel4node with write-excel-file to remove vulnerability - #1883
Merged
Conversation
2 new issues
|
|
Coverage Impact This PR will not change total coverage. Modified Files with Diff Coverage (2)
🛟 Help
|
…mitive branches Export toCell and unit-test the cast paths qlty flagged as uncovered: numeric string to Number, non-primitive to String, and the false boolean-string branch. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Tonours
reviewed
Sep 8, 2026
…ject non-finite values Address review on the excel4node -> write-excel-file migration: - name the worksheet 'Export' again (default was 'Sheet1', breaking Export!A1 refs) - match excel4node's default 'm/d/yy' date format instead of yyyy-mm-dd hh:mm:ss - send non-finite numbers and invalid dates as text/empty instead of shipping <v>NaN</v>/<v>Infinity</v>, which made Excel offer to repair the file - guard numeric strings with Number.isFinite so 'Infinity'/'1e309' stay text - extract the date format into a file-local constant Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Tonours
approved these changes
Sep 8, 2026
forest-bot
added a commit
that referenced
this pull request
Sep 8, 2026
## @forestadmin/plugin-export-advanced [1.1.50](https://github.com/ForestAdmin/agent-nodejs/compare/@forestadmin/plugin-export-advanced@1.1.49...@forestadmin/plugin-export-advanced@1.1.50) (2026-09-08) ### Bug Fixes * **security:** replace excel4node with write-excel-file to remove vulnerability ([#1883](#1883)) ([a9dbd1d](a9dbd1d))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Definition of Done
General
Security
Note
Replace
excel4nodewithwrite-excel-filein xlsx export pluginexcel4nodedependency withwrite-excel-fileto remove a security vulnerability inplugin-export-advancedwrite-excel-filecell descriptors, encoding booleans, numbers, and dates as typed cellsaddExportAdvancednow awaits the renderer output before returning the file resulttoCellin xlsx.ts now infers types, converting numeric strings to numbers and lowercase boolean strings to booleans, changing how some data is represented in exported spreadsheetsChanges since #1883 opened
toCellutility withinplugin-export-advancedto convert non-finite numeric values (NaN, Infinity, -Infinity) to string cells instead of number cells, and to return null for invalid Date instances [dba86e3]XLSX_DATE_FORMATconstant [dba86e3]writeXlsxFilefunction call inplugin-export-advancedto specify the worksheet name as 'Export' [dba86e3]Macroscope summarized 5a6cf6e.