Repository navigation
docs: never edit a changelog - #626
Merged
Merged
Conversation
⚪ Nothing to measureNo package a gate benchmarks changed. Not run, nothing they build on changed: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Type of change
Description of the changes
AGENTS.md's Pull requests section now forbids editing a changelog:
docs/changelog.md,sdk/python/CHANGELOG.mdandmcp/CHANGELOG.mdbelong to release-please, in every pull request, release pull requests included. To change what a release says, change the title of the pull request it comes from.Motivation for the changes
Release-please writes the changelogs from the squash-commit titles on
main. A hand-written entry is either overwritten by the next release pull request or ships a line no commit backs, and fixing a release pull request's CI (as on #625) is exactly when the temptation arises.Breaking change?
If yes, fill this in
What breaks:
Before → after:
Migration:
How it was tested
pre-commit run --files AGENTS.mdpasses.Performance regression
Checklist
Notes for reviewers