Repository navigation
[1.0.0] Add a depth limit when decoding. - #17
Merged
Merged
Conversation
…t of 16, which is much more than LDAP or SNMP needs, and is the primary use of this library.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
============================================
+ Coverage 96.80% 96.99% +0.18%
- Complexity 456 458 +2
============================================
Files 29 29
Lines 1313 1329 +16
============================================
+ Hits 1271 1289 +18
+ Misses 42 40 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a depth limit when decoding so we don't infinitely recurse, since we can be decoding PDUs from many contexts from sources we potentially do not trust. This defaults it to 16, which is greater than what's needed by LDAP / SNMP (primary uses for this library). PHP can handle a depth far greater before it becomes too much. So this just stops it at a sane limit.
Also fixing the CS settings in this repo and aligning it with the LDAP library.