Skip to content

[1.0.0] Protect server-owned attributes and fix response spelling. - #369

Merged
ChadSikorra merged 5 commits into
FreeDSx:mainfrom
ChadSikorra:fix/server-owned-attributes
Oct 21, 2026
Merged

ChadSikorra merged 5 commits into
FreeDSx:mainfrom
ChadSikorra:fix/server-owned-attributes

Conversation

@ChadSikorra

Copy link
Copy Markdown
Contributor

A couple of updates to server side writes:

  • Refuse server owned attributes for all validation modes (special cases on an add still apply).
  • Make sure modifyTimestamp stays consistent.
  • Return the correct response code for non-ascii attribute descriptions. Also refuse empty attribute descriptions in all contexts.

Also addresses things around spellings of DNs / attributes for how clients see them in responses.

@ChadSikorra
ChadSikorra merged commit 5843a4a into FreeDSx:main Oct 21, 2026
14 checks passed
@codecov

codecov Bot commented Oct 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.31507% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.20%. Comparing base (da50671) to head (3b8c5d7).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...Storage/Adapter/Support/ArrayEntryStorageTrait.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #369      +/-   ##
============================================
+ Coverage     90.10%   90.20%   +0.10%     
  Complexity       31       31              
============================================
  Files           755      755              
  Lines         29659    29747      +88     
============================================
+ Hits          26724    26834     +110     
+ Misses         2935     2913      -22     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant