Skip to content

rob schema still rejects and omits the shipped macOS x86_64 archive #28

Closed

Description

@eiei114

What happened

At reviewed commit 4b20d38b4f2c1e01b377f8cd4923a2d6178c5ada, release packaging and the GitHub workflow support four targets, including macos/x86_64, and the published v0.8.0 release now contains that archive and its checksum.

The CLI's separate release-archive model was not updated:

  • release_archive::archive_name rejects ("macos", "x86_64"), and its unit test explicitly expects rejection.
  • rob schema exposes macosAarch64 but no macosX86_64 entry.
  • docs/releasing.md still calls the three-target matrix the approved matrix.
  • The README still says the v0.8.0 Intel archive is being backfilled and recommends source installation until it lands, although the asset is already published.

As a result, coding agents using the advertised offline schema receive release metadata that contradicts the workflow, packer, README target list, and published release.

Expected behavior

The supported release-target matrix should consistently include Windows x86_64, Linux x86_64, macOS aarch64, and macOS x86_64. rob schema should expose the Intel macOS archive name, and release documentation should describe its current published state.

Steps to reproduce

No Roblox access, browser, profile, or credential is needed.

  1. Build and print the offline schema:
cargo build --release --locked
target/release/rob schema > schema.json

(target/release/rob.exe on Windows.)

  1. Inspect data.releaseArchives. It contains windowsX86_64, linuxX86_64, and macosAarch64, but no macosX86_64.

  2. Confirm the contradictory local packer result without creating an archive:

python - <<'PY'
import importlib.util
spec = importlib.util.spec_from_file_location("packer", "scripts/package-release.py")
packer = importlib.util.module_from_spec(spec)
spec.loader.exec_module(packer)
print(packer.archive_name("0.8.0", "macos", "x86_64"))
PY

Observed packer result:

('robcli-0.8.0-macos-x86_64.tar.gz', 'rob')

The Rust matrix still rejects the same target, while the release workflow contains a macos-15-intel job.

Acceptance criteria

  • Accept macos/x86_64 in the Rust release-archive target matrix and update its regression test.
  • Add the robcli-<version>-macos-x86_64.tar.gz entry to rob schema.
  • Update docs/releasing.md to describe the four-target approved matrix.
  • Remove or update the stale README statement that the v0.8.0 Intel archive is still pending.
  • Preserve the archive member allowlist, checksum behavior, existing four workflow jobs, and offline-only schema behavior.

Additional context

Reviewed commit: 4b20d38b4f2c1e01b377f8cd4923a2d6178c5ada.

Stable references:

All open and closed issues, pull requests, issue comments, review bodies, and inline review comments were checked. The partial archive/checksum-pair risk is already recorded on PR #26 and is not duplicated here; no existing report covers this separate target-matrix/schema drift.

Activity

  1. eiei114 commented on Nov 3, 2026

    @eiei114
    CollaboratorAuthor

    Fixed in 4317bfd (release 0.9.0). See changelog.md for the shipped behavior and the offline regressions added with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions