Repository navigation
feat: ship a macos-x86_64 archive and align the packer with rbxoc - #25
Merged
Merged
Conversation
Rokit validates the OS of a downloaded binary but not its architecture, so on an Intel Mac it installed macos-aarch64, reported success, and left `rob` unable to exec. The README worked around that with a warning; this removes the need for one. macos-15-intel is a Standard GitHub-hosted runner (no `-large` or `-xlarge` suffix), so this costs nothing on a public repository. The arm64 job is pinned to macos-15 for the same reason as in rbxoc: name the image explicitly so a `-latest` migration cannot silently move one macOS entry. Two packager fixes ported from rbxoc's copy: - The `.sha256` sidecar is written with an explicit \n. Python's text mode emits CRLF on Windows, which breaks `sha256sum -c`. Verified: the sidecar now ends with a bare newline and `sha256sum -c` reports OK. - A target outside the approved matrix reports the target name. It used to leak a raw KeyError tuple, because `str(KeyError)` is the repr of the key. The publish guard counted exactly three built-commit records; it now expects four, matching the matrix. Verification of the packer paths (local, no release touched): - macos/x86_64 -> robcli-0.8.0-macos-x86_64.tar.gz with rob, license-mit, license-apache. - windows/x86_64 -> zip, sidecar passes `sha256sum -c`. - linux/aarch64 -> "target linux/aarch64 is outside the approved archive matrix". - 0.8.0-rc1 -> "version is not a plain numeric release".
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 6 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
v0.8.0 does not carry macos-x86_64 yet, and the publish guard blocks a backfill for that tag until this change is on main. Saying the archive exists without that caveat would be false at merge time for anyone on exactly 0.8.0.
This was referenced Oct 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two follow-ups recorded against #24, both mechanical:
macos-aarch64, saw success, and then could not execrob. The README documented the trap; this removes it.package-release.pystill wrote the.sha256sidecar in text mode, which emits CRLF on Windows and breakssha256sum -c, and a bad target leaked a rawKeyErrortuple.What
macos-15-intelto the matrix, emittingmacos-x86_64.macos-15, so both macOS entries name their image explicitly.("macos", "x86_64")in the packer..sha256sidecar with an explicit\n.KeyErrorrepr.-eq 3to-eq 4.macos-x86_64.Cost
macos-15-intelis a Standard GitHub-hosted runner — standard-runners table, no-large/-xlargesuffix — so it is free on a public repository.Verification
Packer run locally against the built binary; no release or Roblox endpoint touched:
--os macos --arch x86_64robcli-0.8.0-macos-x86_64.tar.gzwithrob,license-mit,license-apache--os windows --arch x86_64\n,sha256sum -creports OK (it failed before)--os linux --arch aarch64target linux/aarch64 is outside the approved archive matrix--version 0.8.0-rc1version is not a plain numeric releaseWorkflow YAML parses; matrix resolves to
windows-latest/x86_64,ubuntu-latest/x86_64,macos-15/aarch64,macos-15-intel/x86_64. No Rust source changed.Not verified until this merges: the
macos-15-inteljob itself. Backfill ontov0.8.0follows in a separate dispatch.Remaining follow-up (not here)
The archive member is
robwhile the repository isrobcli, so Rokit's member lookup uses its scoring fallback instead of an exact filename match. Renaming changes the archive layout, so it needs its own decision.