fix(tokens): add target-first redemption name aliases - #318
Merged
Merged
Conversation
The client is moving to one naming rule — the symbol, lowercased, with slashes and spaces removed and nothing else touched. 31 assets added after v1.130.0 still carried an older resolver's output: a space where the symbol had one removed too few (`usdcredemption from acred.svg`), an underscore where the symbol has a dash (`rsteth_lidowsteth.svg`), a `_>` where it has `->`, or a slash that turned the name into a subdirectory (`weeth/reth.svg`). Six older ones were simply misnamed — no resolver, old or new, ever asked for `reth_f.svg`, `aurab_reth_stable.svg` or `pt_usdf_29jan2026.svg`, so that artwork has been dead since it landed. rETH-f even had its own icon nobody could reach. Every other asset from v1.130.0 and earlier is left alone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…for byte Each of these 17 was a second copy of an asset that survives under the name its symbol resolves to: `steth_ng.svg` == `steth-ng-f.svg`, `weeth/reth.svg` == `weethreth.svg`, `pt_deth-29jan2026.svg` == `pt-deth-29jan2026.svg`. They existed only because two older resolvers spelled the same symbol differently — the legacy SDK asks for the raw lowercased symbol, ui-kit 3 for a mangled one. Assets from v1.130.0 and earlier are untouched, so anything still resolving the old way keeps its icon. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
doomsower
approved these changes
Sep 7, 2026
doomsower
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 12 icon aliases for target-first phantom symbols such as
USDC redemption from ACRED. The next client removes the first space when resolving the filename, producingusdcredemption from acred.svg.Each icon puts the target asset upper-left and in front, with the source lower-right and behind. Reuses existing token artwork with a transparent separation gap. Covers cp0xLRT, rstETH, pzETH, steak7LRT, Re7LRT, hgETH, liUSD-1w, rsETH, mEDGE, ACRED, STAC, and mF-ONE redemptions. Existing filenames remain available for older SDK versions.
Visually inspected all 12 rendered icons in the in-app browser, parsed the SVGs with xmllint, and passed the Git whitespace check. Filenames follow the inspected next.70 TokenIcon resolver; this does not claim a fresh full-chain audit. Publish these assets before SDK naming PR Gearbox-protocol/sdk#506 is released.