Repository navigation
feat: add NetworkError.gone for HTTP 410 - #3
Merged
Merged
Conversation
The resource existed and is permanently gone — distinct from 404, and exactly what an expired challenge link maps to. Without it buildError(from: 410) degraded to .unknown. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cz7KThgfTBVH8Y3wUju6GX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
case gone = 410toNetworkError, with alocalizedDescriptionentry.Why
410 Gone is the semantically correct status for a permanently-expired resource (RFC 9110). Without the case,
buildError(from: 410)degraded to.unknown, which erases the signal downstream consumers need — MatchWords' challenge-links backend uses 410 for expired challenges (documentation/CHALLENGE_LINKS.md).Verification
swift test: 24/24 green. The existingNetworkErrorTestCase.testErrorCodeMatchingiteratesallCases, so the new case is pinned (round-trip + non-empty description) with no new test needed.🤖 Generated with Claude Code
https://claude.ai/code/session_01Cz7KThgfTBVH8Y3wUju6GX