Repository navigation
fix(docs): make the site check fail on self-closed raw tags and bad config, never crash - #31
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared site check let a few broken pages through and crashed on one kind of bad link. A self-closed
<textarea/>hides the rest of a page in a browser, because HTML ignores that slash, but the check read it as empty. A%00in a link path stopped the check with a traceback instead of an error line. Atheme.featuresstring, aredirect_mapsthat is not a table, a site URL without a scheme, or a home page with no content block passed without a word.What changes:
.github/scripts/site-check.py(and, on a list,docs/hooks/awesome_site.py) is the new shared copy. Each case above is now an ERROR line; a redirect stub is recognised by its parsed title, and the list's include line may use either quote and CRLF line endings.Verified: planted controls on a real build, each new rule red before and green after the fix, with the error message checked; all 58 sites in the fleet build and check clean with it.
Summary by CodeRabbit