Skip to content

fix(network): Port merged TheSuperHackers lobby and network leak fixes - #640

Open
tintinhamans wants to merge 4 commits into
GeneralsOnlineDevelopmentTeam:mainfrom
tintinhamans:arctic/go/fix/upstream-network-leaks
Open

tintinhamans wants to merge 4 commits into
GeneralsOnlineDevelopmentTeam:mainfrom
tintinhamans:arctic/go/fix/upstream-network-leaks

Conversation

@tintinhamans

Copy link
Copy Markdown

Ports four merged upstream leak fixes in the LAN and network code. Each is a cherry-pick -x of the upstream commit.

For TheSuperHackers#3462 the GameInfo destructor that upstream adds already exists on this branch, so only the virtual destructors on the subclasses and the LANAPI changes are taken. The Recorder.h and GameSpyGameInfo.h changes are applied to both the Generals and GeneralsMD copies, Recorder.h with just the one destructor line because those files differ from upstream.

Zero Hour (z_generals) builds here. The Generals copies of Recorder.h and GameSpyGameInfo.h were not compiled, g_generals does not build on this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant