Repository navigation
fix(network): Port merged TheSuperHackers lobby and network leak fixes - #640
Open
tintinhamans wants to merge 4 commits into
Open
tintinhamans wants to merge 4 commits into
tintinhamans wants to merge 4 commits into
Conversation
…PI::RequestGameLeave() (TheSuperHackers#3462) (cherry picked from commit ac4965a)
(cherry picked from commit 2d6761c)
…heSuperHackers#3498) (cherry picked from commit a8464bc)
…perHackers#3499) (cherry picked from commit 4a4a1b2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports four merged upstream leak fixes in the LAN and network code. Each is a
cherry-pick -xof the upstream commit.For TheSuperHackers#3462 the
GameInfodestructor that upstream adds already exists on this branch, so only the virtual destructors on the subclasses and theLANAPIchanges are taken. TheRecorder.handGameSpyGameInfo.hchanges are applied to both theGeneralsandGeneralsMDcopies,Recorder.hwith just the one destructor line because those files differ from upstream.Zero Hour (
z_generals) builds here. TheGeneralscopies ofRecorder.handGameSpyGameInfo.hwere not compiled,g_generalsdoes not build on this branch.