Repository navigation
fix(lobby): Keep Unicode characters in the saved lobby name - #642
Open
tintinhamans wants to merge 1 commit into
Open
tintinhamans wants to merge 1 commit into
tintinhamans wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PopupHostGameSystemkept only the low byte of each character when saving the last lobby name toCustomPref.ini, so anything above U+00FF came back as unrelated Latin-1 characters.UserPreferencesnow hasgetUnicodeStringandsetUnicodeString, which convert throughtranslatethe same way the rest of the engine does.CustomMatchPreferences::getLastLobbyNameandsetLastLobbyNametake aUnicodeStringand use them, soPopupHostGamejust passes the name through.A name already saved with characters above U+007F loads wrong once. Saving it again fixes it.