Skip to content

fix(session): coordinate lifecycle and lobby membership cleanup #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tintinhamans wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

fix(session): coordinate lifecycle and lobby membership cleanup #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a41ff8d
refactor(lobby): centralize membership commands and state ownership
tintinhamans Oct 16, 2026
21f3585
refactor(lobby): align membership operation names
tintinhamans Oct 16, 2026
f7ea233
refactor(matchmaking): separate detachment from membership effects
tintinhamans Oct 16, 2026
50d2a68
refactor(matchmaking): align detachment operation names
tintinhamans Oct 16, 2026
3aaa008
fix(session): serialize lifecycle cleanup with membership changes
tintinhamans Oct 16, 2026
b8f6809
fix(lobby): make membership transfers and cleanup race-safe
tintinhamans Oct 16, 2026
f0f7c7e
refactor(session): clarify lifecycle operation names
tintinhamans Oct 16, 2026
b448c87
fix(lobby): keep matchmaking exits within membership ownership
tintinhamans Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
320 changes: 85 additions & 235 deletions GenOnlineService/Constants.cs
View file
Open in desktop

Large diffs are not rendered by default.

13 changes: 3 additions & 10 deletions GenOnlineService/Controllers/Lobbies/LobbiesController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,8 +328,6 @@ public async Task<APIResult> Put()

if (playerSession != null)
{
// cleanup any zombie lobbies
await _lobbyManager.CleanupUserLobbiesNotStarted(user_id);

await using var db = await _dbFactory.CreateDbContextAsync();
string strDisplayName = await Database.Users.GetDisplayName(db, user_id);
Expand All @@ -342,14 +340,9 @@ public async Task<APIResult> Put()
result.result = 1;
result.lobby_id = newLobbyID;

// TODO: What if this fails? just let them proceed? just means only direct connect people will be able to play
// get some turn credentials
TURNCredentialContainer? turnCredentials = await TURNCredentialManager.CreateCredentialsForUser(user_id);
if (turnCredentials != null)
{
result.turn_username = turnCredentials.m_strUsername;
result.turn_token = turnCredentials.m_strToken;
}
var credentials = await _lobbyManager.CreateLobbyRelayCredentialsAsync(playerSession, newLobbyID);
result.turn_username = credentials.Username;
result.turn_token = credentials.Token;
}
else
{
Expand Down
Loading
Loading