fix(ci): publish the /v1/games pointer instead of deleting it - #189
Merged
Merged
Conversation
The step existed because ~1M game pages blew the Pages deployment window. Games now live in game-catalog and the path holds a 357-byte pointer to it, which this step was deleting — the URL 404s instead of redirecting. Refs #1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deploy workflow still pruned
_site/v1/gamesand strippedgamesfrom the manifest — a workaround from when ~1M game pages exceeded the Pages deployment window. Games moved to game-catalog, and the path now holds a 357-byte pointer, which the step was deleting: https://gettechapi.github.io/TechAPI/v1/games/index.json returns 404.Refs #1