fix: honor weekly refresh history and phone scoring config - #68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetch-depth: 0for the TechAPI checkout inweekly-refresh.ymlso dump timestamps use complete git history.weights.phone_overallandweights.valuefromconfig/scoring.yamlin phone scoring instead of hardcoded formulas.Scoring impact
The current configured
phone_overallweights areperformance: 0.30,camera: 0.25,battery: 0.20, anddisplay: 0.25, whereas the previous implementation used an equal 25% average. The currentvalueconfiguration is already 50/50, so value scoring remains equivalent. Overall scores may change for phones whose component scores differ; this is the intended effect of activating the existing configuration.Validation
appand scoring services): passed