Skip to content

fix: honor weekly refresh history and phone scoring config - #68

Merged
Seungpyo1007 merged 1 commit into
mainfrom
fix/weekly-refresh-scoring-config
Sep 18, 2026
Merged

Seungpyo1007 merged 1 commit into
mainfrom
fix/weekly-refresh-scoring-config

Conversation

@Seungpyo1007

Copy link
Copy Markdown
Member

Summary

  • Set fetch-depth: 0 for the TechAPI checkout in weekly-refresh.yml so dump timestamps use complete git history.
  • Apply weights.phone_overall and weights.value from config/scoring.yaml in phone scoring instead of hardcoded formulas.
  • Add regression coverage for configured overall/value weights.

Scoring impact

The current configured phone_overall weights are performance: 0.30, camera: 0.25, battery: 0.20, and display: 0.25, whereas the previous implementation used an equal 25% average. The current value configuration is already 50/50, so value scoring remains equivalent. Overall scores may change for phones whose component scores differ; this is the intended effect of activating the existing configuration.

Validation

  • Targeted scoring tests: 17 passed
  • Ruff: passed
  • Mypy (app and scoring services): passed
  • Full pytest: 280 passed, 1 skipped; 28 unrelated integration failures because the TechAPI data submodule is not populated in this worktree.

@Seungpyo1007 Seungpyo1007 self-assigned this Sep 18, 2026
@Seungpyo1007
Seungpyo1007 merged commit 5608ec9 into main Sep 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant