feat(verify): gate Wikipedia GPU URL backfill - #72
Merged
Merged
Conversation
Refuse a confirm when a Mobility, Mobile, Go, Max-Q, or M-suffix marker is only on one side, when an AGP section is paired with a PCIe record, when only the launch year agrees, or when two same-named core rows remain. --apply appends the Wikipedia URL to source_urls for confirms only.
Bind each record name once so the str check narrows it, and keep the form-factor sample off the scored-row variable. Gate behavior is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Wikipedia GPU backfill now refuses a confirm when a desktop card and a laptop card share a model number. A Mobility, Mobile, Go, Max-Q, or numeric M suffix on only one side drops that row before scoring. An AGP section no longer confirms a PCIe record, a launch year alone is not enough, and two same-named core rows stay ambiguous.
How
app.verify.wikipedia_gpu_backfillreads the Wikipedia list pages already used for ingest, plus the Quadro article.--applyappends the Wikipedia URL tosource_urlsfor CONFIRM rows only. Dry-run remains the default.Testing
ruff checkon the module and its tests passed.pytest tests/verify/test_wikipedia_gpu_backfill.py— 21 passed.Checklist
ruff checkandpytestpass locallypython -m app.validate— this PR does not change data files