Skip to content

fix(print): accept Windows setup PDFs with softened edges - #135

Merged
Go2Engle merged 1 commit into
mainfrom
feature/windows-template-capture
Oct 26, 2026
Merged

Go2Engle merged 1 commit into
mainfrom
feature/windows-template-capture

Conversation

@Go2Engle

@Go2Engle Go2Engle commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

Summary

Windows Design Space setup PDFs can be rejected as slightly oversized even when the Canvas dimensions are correct. Narrow softened edges in the compressed magenta image push the measured footprint beyond the size limit. Accept these captures using their solid edges, while retaining the existing geometry and registration checks.

Fixes #134.

Type of Change

Bug Fix

Technical Details

  • Recover at most 0.2 mm of softened fringe per edge only when continuous opaque magenta edges satisfy the existing 0.3 mm size tolerance.
  • Preserve full slot-pattern, surrounding-mark, artwork-clearance, and output-paper fit validation.
  • Add the public PDF from issue Experimental 8 card template not uploading to CriPox #134 as a regression fixture, including size-check export and rejection of artwork scaled to 99.5% or 100.5%.
  • Test narrow and broad fringes, damaged card interiors, and existing softened-edge captures.
  • Update the feature reference, Cricut workflow guide, and exported handoff instructions with exact metric dimensions and the Windows Tabloid paper setting.

Testing Performed

  • 226 automated tests passed locally.
  • Application production build passed.
  • Browser reproduction with PDF.js 6.4.299 confirmed the reported 177.41 × 255.35 mm rejection before the fix.
  • Both the issue PDF and a second independently captured Windows PDF pass the corrected browser detector and Letter-fit check.
  • Regression export confirms the setup magenta is covered in the rendered size-check PDF.
  • PR checks passed on Windows and Linux, including the website build, documentation checks, and CodeQL.
  • Cross-platform test installers: build run, building commit c7527c8b6482cb15ff9881814527d713b26ad964 from feature/windows-template-capture.
  • Physical Windows print-and-cut validation passed: the maintainer printed a full sheet of eight card fronts using the Windows test build and reported that all eight cards cut correctly.
npm test
npm run build

Breaking Changes

None. Captured marks and artwork remain at their original scale; no project or capture format changes.

@Go2Engle
Go2Engle marked this pull request as ready for review October 26, 2026 01:22
@Go2Engle
Go2Engle merged commit 1443bb5 into main Oct 26, 2026
13 checks passed
@Go2Engle
Go2Engle deleted the feature/windows-template-capture branch October 26, 2026 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Experimental 8 card template not uploading to CriPox

1 participant