fix: validate config.yaml services and cache parsed result - #100
Merged
Conversation
ServiceConfig was hand-rolled and load_services() re-parsed config.yaml on every call (invoked from several per-request paths). Malformed entries raised a raw KeyError and duplicate service names silently clobbered each other in the payload namespace. Fixes #76. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ServiceConfigis now a validated Pydantic model instead of a hand-rolled class, so malformedconfig.yamlentries raise a clear error instead of a rawKeyError.config.yamlnow raise aRuntimeErrorinstead of silently sharing theservicepayload namespace.Settings.load_services()now caches the parsed result per instance instead of re-reading and re-parsing the YAML file on every call (it's invoked from several per-request paths:search.py,stats.py,service_registry.py, both indexing pipelines).Fixes #76.
Test plan
uv run pytest tests/test_config.py -q— 11 passed, including new tests for invalid entries, duplicate names, and caching.uv run pytest -q— full suite, 292 passed.🤖 Generated with Claude Code