Conversation
A key like urgency.uda.tags.foo.coefficient was accepted silently and only took effect when a task had exactly one tag, since it compared the whole tags value against "foo". Stop loading urgency.uda.* coefficients for built-in attributes, and have `task show` list urgency.uda.<name>.* keys whose <name> is not a defined UDA as unrecognized, with a pointer to urgency.user.tag.<tag>.coefficient. Closes GothenburgBitFactory#3726
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A config key like
urgency.uda.tags.foo.coefficientwas silently accepted:task showdidn't flag it, and it only affected urgency when a task had exactly one tag, because it compared the whole tags value to "foo". The intended key isurgency.user.tag.foo.coefficient.As suggested in the issue, this now warns instead of trying to process these keys.
task showlistsurgency.uda.<name>.*entries whose<name>isn't a defined UDA as unrecognized and adds a hint pointing aturgency.user.tag.<tag>.coefficient. Coefficients for built-in attributes liketagsare no longer loaded. Real UDAs, including the defaultpriority, are unaffected.Tested with new cases in show.test.py (flagged for tags, not flagged for a defined UDA or priority) and urgency.test.py (the tags coefficient no longer changes urgency). Full ctest suite passes.
Closes #3726