Skip to content

test: skip transient TLS integration failures #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GottenHeave merged 1 commit into from
May 25, 2026
Merged

test: skip transient TLS integration failures #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions backend/internal/pkg/tlsfingerprint/dialer_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ package tlsfingerprint
import (
"context"
"encoding/json"
"errors"
"io"
"net/http"
"strings"
Expand All @@ -24,14 +25,18 @@ func skipIfExternalServiceUnavailable(t *testing.T, err error) {
t.Helper()
if err != nil {
// Check for common network/TLS errors that indicate external service issues
errStr := err.Error()
errStr := strings.ToLower(err.Error())
if strings.Contains(errStr, "certificate has expired") ||
strings.Contains(errStr, "certificate is not yet valid") ||
strings.Contains(errStr, "connection refused") ||
strings.Contains(errStr, "connection reset by peer") ||
strings.Contains(errStr, "no such host") ||
strings.Contains(errStr, "network is unreachable") ||
strings.Contains(errStr, "timeout") ||
strings.Contains(errStr, "deadline exceeded") {
strings.Contains(errStr, "deadline exceeded") ||
strings.Contains(errStr, "tls handshake failed: eof") ||
strings.Contains(errStr, "unexpected eof") ||
errors.Is(err, io.EOF) {
t.Skipf("skipping test: external service unavailable: %v", err)
}
t.Fatalf("failed to get fingerprint: %v", err)
Expand Down
Loading