Skip to content

Fix: Show the empty change message when the browser sends no referrer - #877

Merged
jochengcd merged 1 commit into
GrandComicsDatabase:betafrom
ProfNardi:fix/empty-change-without-referrer
Nov 12, 2026
Merged

jochengcd merged 1 commit into
GrandComicsDatabase:betafrom
ProfNardi:fix/empty-change-without-referrer

Conversation

@ProfNardi

Copy link
Copy Markdown
Contributor

Description

Submitting a change with no comment and no change to the data shows a message with a "Go back" link to the referrer. A browser that sends no referrer got a server error instead of the message. The message now appears, and in that case its link goes to the edit page of the change.

Testing

apps/oi/tests/test_submit_empty_change.py submits such a change with and without a referrer and checks the link. Without the change the case with no referrer fails with KeyError: 'HTTP_REFERER'. Full suite: 1010 passed, 0 failed.

@coderabbitai

coderabbitai Bot commented Nov 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 41 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fd9c50a4-555d-4780-8c0f-c7e2d71fddc4
Commits

Reviewing files that changed from the base of the PR and between 4873e6c and 7c7c825.

Files selected for processing: 2

  • apps/oi/tests/test_submit_empty_change.py
  • apps/oi/views.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@jochengcd
jochengcd merged commit aaca01a into GrandComicsDatabase:beta Nov 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants