Repository navigation
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 41 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
jochengcd
reviewed
Nov 13, 2026
| # check if this is a request to add a copy of a sequence | ||
| if 'copy' in request.GET or 'copy_cover' in request.GET: | ||
| issue_revision = changeset.issuerevisions.get(id=issue_revision_id) | ||
| issue_revision = get_object_or_404(changeset.issuerevisions, |
Contributor
There was a problem hiding this comment.
While the other two can be obtained by editing an URL, this one I am not sure if users edits of URLs can find this.
If not, these only would be due to errors in our workflow, which we want to know about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding a series to a publisher that does not exist, or a sequence to an issue revision that is not in the change, should show an error page with a message. The message was built by adding an integer to a string, so these addresses ended in a server error. They now show the message.
The Copy buttons of the add sequence form ended in a server error on such a revision too. They now give a page not found, as an unknown change already does in the same view.
Testing
apps/oi/tests/test_add_unknown_id.pyopens the add series and add sequence addresses and both Copy buttons. Without the change all four tests fail. Full suite: 1012 passed, 0 failed.