Repository navigation
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 41 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The lists of creators and of creator names of a publisher, a series and a feature show an issue count for each person, with a link to those issues. The count included credits for editing, which the issue lists leave out: a person credited only for editing showed 1 and opened an empty list, and a person with other credits could show too many issues.
These lists now follow the rule already used on the lists of a character and a group. Credits for editing are not counted, so a person credited only for editing is no longer listed on them. The list of issues of a creator name on a feature applies the same rule to the sequences with that feature.
Testing
apps/gcd/tests/test_creator_list_counts.pyopens the lists of names and of creators of a publisher, a series and a feature of each kind, and the issues of a name on a feature. Without the change all nine cases fail. Full suite: 1017 passed, 0 failed.