Fix #82: Filter blocked contacts from notification query - #346
Open
navneetsingh-dev wants to merge 1 commit into
Open
navneetsingh-dev wants to merge 1 commit into
navneetsingh-dev wants to merge 1 commit into
Conversation
RankoR
self-requested a review
September 27, 2026 17:15
RankoR
suggested changes
Sep 27, 2026
RankoR
left a comment
RankoR
left a comment
Contributor
There was a problem hiding this comment.
In addition to other comments:
- Why changes other than to two java files are needed?
- Tests are missing. Such changes must be well covered by tests
| + " AND " | ||
| + "(" + DatabaseHelper.PARTICIPANTS_TABLE + "." + ParticipantColumns.BLOCKED | ||
| + " = 0 OR " + DatabaseHelper.PARTICIPANTS_TABLE + "." | ||
| + ParticipantColumns._ID + " IS NULL)" |
Contributor
There was a problem hiding this comment.
Missing closing ).
Can be fixed with ParticipantColumns._ID + " IS NULL))" or, better, ifnull(participants.blocked, 0) = 0
| final String contentLocation, final int subId, final String subPhoneNumber, | ||
| final int statusIfFailed, final boolean autoDownload, final String transactionId, | ||
| final int resultCode) { | ||
| final Uri notificationUri, final String conversationId, final String participantId, |
Contributor
There was a problem hiding this comment.
Please revert indentation changes
navneetsingh-dev
force-pushed
the
fix-blocked-contacts
branch
3 times, most recently
from
September 27, 2026 21:01
b610495 to
f6d9422
Compare
navneetsingh-dev
force-pushed
the
fix-blocked-contacts
branch
from
September 27, 2026 21:07
f6d9422 to
285b948
Compare
Author
|
All requested changes are complete and the CI checks are fully passing! Applied the ifnull logic for blocked contacts. Reverted the accidental formatting in ProcessDownloadedMmsAction.java. Added a clean, passing regression test for the new logic. Let me know if there's anything else you need before merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #82. This new branch includes the clean commit history and the updated SQL query to preserve senderless notifications as requested by @thestinger