Repository navigation
Fix dcpext random crashes - #25
Merged
Merged
Conversation
For segments where the device address equals the physical address, macOS doesn't actually map them. These seem to be data reservations. Creating the mappings can mess with the firmware heap, so don't. Signed-off-by: Niklas Sheth <hi@niklassheth.com>
This hack is no longer necessary, it doesn't create mappings and nothing uses the reservations. Signed-off-by: Niklas Sheth <hi@niklassheth.com>
dcpext no longer crashes randomly, so enable it on the mini Signed-off-by: Niklas Sheth <hi@niklassheth.com>
Member
|
Tested on Neo and M4 Max MBP 16in. Idk if it fixes the DCP crashes but it doesn't regress for sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS seems to never map segments where the device address equals the physical address. Depending on where they end up, these mappings can crash the coproc's firmware. In particular, dcpext crashes 10% of the time without this fix on the M4 mini.
Stop creating those mappings, remove a hack that depended on them, and re-enable dcpext on the mini.