Repository navigation
dart: poll the correct T8110 TLB command register - #28
Merged
Merged
Conversation
It appears this is a typo in the original code that results in polling the wrong offset, 0x700 instead of 0x80. The value at 0x700 happens to also contain zero, and for most darts it appears that polling isn't required because by the time of the first poll the busy bit is already unset. The exception is the DCP on T8140 where this issue causes the DCP to fail to start. The Linux driver is already correct. Assisted-By: LLM Signed-off-by: Cody Ho <codyho@stanford.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears this is a typo in the original code that results in polling the wrong offset, 0x700 instead of 0x80. The value at 0x700 happens to also contain zero, and for most darts it appears that polling isn't required because by the time of the first poll the busy bit is already unset. The exception is the DCP on T8140 where this issue causes the DCP to fail to start.
The Linux driver is already correct.
Assisted-By: LLM