Skip to content

dart: poll the correct T8110 TLB command register - #28

Merged
ADevWithAnIdea merged 1 commit into
mainfrom
PR_dart_flush_fix
Nov 19, 2026
Merged

ADevWithAnIdea merged 1 commit into
mainfrom
PR_dart_flush_fix

Conversation

@ADevWithAnIdea

Copy link
Copy Markdown
Member

It appears this is a typo in the original code that results in polling the wrong offset, 0x700 instead of 0x80. The value at 0x700 happens to also contain zero, and for most darts it appears that polling isn't required because by the time of the first poll the busy bit is already unset. The exception is the DCP on T8140 where this issue causes the DCP to fail to start.

The Linux driver is already correct.

Assisted-By: LLM

It appears this is a typo in the original code that results in polling
the wrong offset, 0x700 instead of 0x80. The value at 0x700 happens to
also contain zero, and for most darts it appears that polling isn't
required because by the time of the first poll the busy bit is already
unset. The exception is the DCP on T8140 where this issue causes the DCP
to fail to start.

The Linux driver is already correct.

Assisted-By: LLM
Signed-off-by: Cody Ho <codyho@stanford.edu>
@ADevWithAnIdea
ADevWithAnIdea merged commit ac17c97 into main Nov 19, 2026
1 of 5 checks passed
@ADevWithAnIdea
ADevWithAnIdea deleted the PR_dart_flush_fix branch November 19, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant