This repository was archived by the owner on Sep 30, 2026. It is now read-only.
Repository navigation
Stop shipping dev-only vendoring rake tasks in the packaged gem - #35
Merged
Merged
Conversation
The gemspec included lib/axe/cuprite/tasks/*.rake in spec.files, so the published gem shipped axe:update / axe:verify / axe:version. These are dev-only: they target the gem's read-only, version-pinned vendor/ dir, and axe:verify can't run from an installed gem because its recorded checksum (axe.min.js.sha512) isn't shipped. Drop the .rake glob from spec.files; the tasks remain available in a repo checkout for development. Closes #32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
axe-cuprite.gemspecincludedlib/axe/cuprite/tasks/*.rakeinspec.files, so the published gem shipped the dev-onlyaxe:update/axe:verify/axe:versiontasks. These are broken for consumers:vendor/directory, which is read-only and version-pinned in an installed gem — re-vendoring a different axe version makes no sense.axe:verifycan't run from an installed gem at all: it readsaxe.min.js.sha512, which isn't inspec.filesand so isn't shipped, aborting with "No recorded checksum … run rake axe:update first."Fix
Remove
"lib/axe/cuprite/tasks/*.rake"fromspec.files. The vendoring tasks are a development-time concern (CI runsaxe:verifyfrom a checkout); consumers never need them. Thelib/**/*.rbglob doesn't catch.rakefiles, so nothing else re-includes them.Verified via
Gem::Specification.load(...)thatspec.filesno longer contains anyrake/tasks/sha512entries.Closes #32