Repository navigation
Match bridgetown-quick-search plugin conventions - #12
Merged
Merged
Conversation
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bridgetown-stoanpm companion in host Bridgetown sites via gemspec metadata. Safe now thatbridgetown-stoa@0.2.0is published (was held back in Add Tailwind v4 styling foundation #10 because the init-time registry lookup 404'd during tests until first publish).frontend/from the gem'sfilesglob — the CSS partial belongs in the npm package only, not double-shipped via the gem.require_gem: falseto the test fixture'sinit :"bridgetown-stoa"so Bridgetown's plugin manager doesn't runinstall_npm_dependenciesduring tests (which would inject a self-referencingbridgetown-stoadep into the gem's ownpackage.jsonon everycibuild).Background
The first commit (
Enable npm_add gemspec metadata) just uncommented the gemspec template'snpm_addblock. Runningcibuildagainst that revealed two problems:"bridgetown-stoa": "^0.2.0"into our ownpackage.json— a permanent footgun if accidentally committed.frontend/styles/bridgetown-stoa.css, double-distributing with the npm companion.The second commit (
Match bridgetown-quick-search plugin conventions) studies the canonical example and adopts its conventions:yarn-addinstead ofnpm_add(synonyms in Bridgetown's source;yarn-addis the ecosystem-standardized name — the gemspec template'snpm_addis the older form).frontend/excluded from the gem'sfilesglob.require_gem: falsein the fixture's initializer. The gem is already loaded bytest/helper.rb, so the re-require (which is what triggersinstall_npm_dependencies) is redundant. This is an API-supported escape hatch —init's signature isinit(name, require_gem: true, require_initializer: true, ...).Test plan
script/cibuildpasses in ~30ms with zero npm noise — no install commands, no 404s, nopackage.jsonmutation.git statusis clean aftercibuildfinishes.🤖 Generated with Claude Code