Skip to content

fix(desktop): localize appearance settings in zh-CN - #202

Merged
Zongwei9888 merged 1 commit into
HKUDS:mainfrom
lihuiyang1024:fix/desktop-appearance-i18n
Sep 6, 2026
Merged

fix(desktop): localize appearance settings in zh-CN#202
Zongwei9888 merged 1 commit into
HKUDS:mainfrom
lihuiyang1024:fix/desktop-appearance-i18n

Conversation

@lihuiyang1024

Copy link
Copy Markdown
Contributor

Description

Follow-up to #154 and #187.

The zh-CN locale currently translates the Appearance section heading, but the controls beneath it remain in English. This completes that high-visibility Settings surface while preserving inline English strings as the source-of-truth fallbacks.

Changes Made

  • localize the appearance mode cards and their accessible group label
  • localize theme names, conversation width, font size, and preferred-font controls
  • localize installed-font groups, guidance, local-only note, and reset action
  • extend the existing language-switch integration test to cover the Appearance surface

Verification

  • npm run typecheck
  • npm run lint
  • npm test — 31 files, 195 tests passed
  • npm run build

Checklist

  • Changes tested locally
  • Code reviewed
  • Documentation updated (not required; UI copy only)
  • Unit tests added

@lihuiyang1024
lihuiyang1024 force-pushed the fix/desktop-appearance-i18n branch from 5002989 to 2fd319e Compare September 5, 2026 09:37
@Zongwei9888
Zongwei9888 merged commit e40c665 into HKUDS:main Sep 6, 2026
14 checks passed
@Zongwei9888

Copy link
Copy Markdown
Collaborator

Merged today as e40c665 (via "Merge PR #202"). With this and #187 the Desktop shell is essentially fully localized for zh-CN; the computed theme keys and the extended language-switch test both read well. Thank you.

@lihuiyang1024
lihuiyang1024 deleted the fix/desktop-appearance-i18n branch September 7, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants