Repository navigation
Fix RESP stream framing and concurrent command handling - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TCP chunks are no longer treated as complete commands. A byte-counted RESP2 parser buffers fragments, drains pipelines in order, and preserves binary keys/values. Worker IPC replies are correlated, conditional SET is atomic in the primary, and lazy expiry prevents an older timer deleting a newer value. Correct bulk/integer/error replies make redis-cli behavior consistent.
The README explains the implemented/unsupported scope, request limits, in-memory retention/backpressure limits, and benchmark overhead. The benchmark package script now names the file that exists. No measured speedup or new licensing terms are claimed.
Validation: 8 native TCP/cluster tests passed with two workers, including split/coalesced/binary/error/concurrent-client cases; the existing redis-cli shell suite also passed against an isolated server. Added Node 22/24 CI. No external Redis replacement or production-readiness claim.