Repository navigation
CI: also run the tests in a debug build - #43
Merged
Merged
Conversation
Release builds wrap on integer overflow and skip debug_assert!s, which is how #41 (a usize underflow) went unnoticed. A new `test-debug` job runs `cargo test` in a debug build on Linux and macOS, in parallel with the release test jobs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cjfields
changed the base branch from
perf/corrected-endsfree-pruning
to
main
October 15, 2026 03:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #42. Retarget to
mainafter #42 merges. Until then, a debug run onmainfails, because threecorrected_endsfreetests hit #41.Release builds wrap on integer overflow and skip
debug_assert!s. That's how #41 (ausizeunderflow, a panic in debug) went unnoticed: CI only rancargo test --release.test-debugjob runscargo test(debug build: overflow checks and debug assertions on) onubuntu-latestandmacos-latest. It runs in parallel with the releasetestjobs, so CI wall time is unchanged. Both architectures, since the x86 and ARM SIMD paths differ.test_vs_reference.test_vs_reference, and passes on top of Speed up Compat::Corrected ends-free (fast kernel, exact pruning); fix #41 #42.🤖 Generated with Claude Code