Skip to content

ICON-eCLM: compute albedo for ICONs radiation window - #160

Merged
s-poll merged 2 commits into
masterfrom
dev-icon-albedo
Nov 17, 2026
Merged

s-poll merged 2 commits into
masterfrom
dev-icon-albedo

Conversation

@s-poll

@s-poll s-poll commented Oct 29, 2026

Copy link
Copy Markdown
Member

Summary

eCLM now computes the albedo for the coupling interval in which ICON uses it, not for the single time step that datm provides via nextsw_cday. Assumes eCLM dtime equals coupling interval with ICON.

Changes

  • compute albedo every coupling step at the current time instead of datms nextsw_cday
  • average cosz over the coupling interval
  • avoids night-flag albedo (=1) sent to ICON while the sun is still up in its radiation window

- compute albedo every coupling step at the current time instead of datms nextsw_cday
- average cosz over the coupling interval
- avoids night-flag albedo (=1) sent to ICON while the sun is still up in its radiation window
@AGonzalezNicolas
AGonzalezNicolas marked this pull request as ready for review October 30, 2026 07:15
Copilot AI balanced review requested due to automatic review settings October 30, 2026 07:15

This comment was marked as resolved.

@kvrigor

kvrigor commented Oct 30, 2026

Copy link
Copy Markdown
Member

🔵 Needs a closer look

Missing ICON-side radiation-window and coupling-lag configuration leaves the exported albedo’s consumption interval unconfirmed, requiring coupled sunrise/sunset validation of [current time, current time + dtime].

No open issues 🎉

What changed in this PR
Review effort: Balanced

@AGonzalezNicolas AI-assisted review is OK, but I would say automated bot reviews add noise to the PR.. I would suggest do prompt the AI on your local machine and then based from that write your own review in the pull request

kvrigor
kvrigor previously approved these changes Oct 30, 2026
- shift the calendar day in shr_orb_cosz by the equation of time as computed in ICON (mo_radiation)
- eCLM and ICON use the same solar hour angle
@s-poll
s-poll merged commit dc7589f into master Nov 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants