Skip to content

Distinguish installed enforcement from demonstrated behavior - #383

Merged
HackingGate merged 1 commit into
mainfrom
feat/enforcement-evidence-20261016
Oct 16, 2026
Merged

HackingGate merged 1 commit into
mainfrom
feat/enforcement-evidence-20261016

Conversation

@HackingGate

@HackingGate HackingGate commented Oct 16, 2026 •

Copy link
Copy Markdown
Owner

Reconciliation establishes installation but does not show that a control can distinguish bad and clean inputs. Add an independent behavior field to human and JSON reports: ordinary checks report unmeasured behavior; uphold check --probe collects fresh measurements without changing the installation verdict or exit status.

Demonstration applies only to the selected runner's named hook and the exercised bad-and-clean controls. Provenance records the runner, declaration, stage, revision, and fixtures. The command verifies a clean snapshot before policy loading, runs that exact revision, and invalidates evidence if either checkout changes, including commits made by a hook. No evidence is stored or reused. Other managers and engine rules behind a wrapper remain unmeasured. Third-party nonzero exits retain the existing probe contract; expect can identify the intended refusal.

Validation: 38 probe CLI tests covering successful controls, failures, missing controls, timeouts, signals, dirty/changed revisions, mutation between controls, manager identity, wrapper boundaries, and human reporting; check CLI tests, structural checks, all-target Clippy, and normal commit/push checks.

Closes #376.

@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.48052% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.71%. Comparing base (3ae2ecf) to head (e656f9b).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/probe.rs 93.62% 16 Missing ⚠️
src/main.rs 91.66% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (94.48%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
+ Coverage   94.61%   94.71%   +0.10%     
==========================================
  Files          46       49       +3     
  Lines       25233    25733     +500     
==========================================
+ Hits        23873    24374     +501     
+ Misses       1360     1359       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from feat/reconciliation-json-20261016 to main October 16, 2026 12:37
@HackingGate
HackingGate force-pushed the feat/enforcement-evidence-20261016 branch from fafaea4 to e656f9b Compare October 16, 2026 12:39
@HackingGate
HackingGate marked this pull request as ready for review October 16, 2026 12:39
@HackingGate
HackingGate merged commit 84536ff into main Oct 16, 2026
12 checks passed
@HackingGate
HackingGate deleted the feat/enforcement-evidence-20261016 branch October 16, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Design: distinguish installed enforcement from demonstrated behavior

2 participants