Skip to content

[Merge] Add errorId to security error responses and enhance logging #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xYunaL merged 2 commits into from
Sep 13, 2026
Merged

[Merge] Add errorId to security error responses and enhance logging #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32bd32e
✨feat: 보안 에러 응답에 errorId 추가 및 로깅 강화
xYunaL Sep 12, 2026
1e3d5e6
Merge pull request #52 from Han-Spoon/hotfix
xYunaL Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 37 additions & 5 deletions src/main/java/com/hanspoon/backend_api/global/config/SecurityConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@
import java.net.URI;
import java.nio.charset.StandardCharsets;
import java.time.OffsetDateTime;
import java.util.UUID;
import javax.crypto.SecretKey;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Value;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
Expand Down Expand Up @@ -36,6 +39,8 @@
@EnableMethodSecurity
public class SecurityConfig {

private static final Logger log = LoggerFactory.getLogger(SecurityConfig.class);

private static final String[] PUBLIC_ENDPOINTS = {
"/",
"/error",
Expand Down Expand Up @@ -104,31 +109,58 @@ public JwtAuthenticationConverter jwtAuthenticationConverter() {

@Bean
public AuthenticationEntryPoint authenticationEntryPoint(ObjectMapper objectMapper) {
return (request, response, exception) ->
writeProblemDetail(objectMapper, response, HttpStatus.UNAUTHORIZED, ErrorCode.INVALID_TOKEN);
return (request, response, exception) -> {
String errorId = UUID.randomUUID().toString();
log.warn(
"Authentication rejected: errorId={}, method={}, path={}, exception={}, cause={}",
errorId,
request.getMethod(),
request.getRequestURI(),
exception.getClass().getSimpleName(),
rootCauseName(exception));
writeProblemDetail(objectMapper, response, HttpStatus.UNAUTHORIZED, ErrorCode.INVALID_TOKEN, errorId);
};
}

@Bean
public AccessDeniedHandler accessDeniedHandler(ObjectMapper objectMapper) {
return (request, response, exception) ->
writeProblemDetail(objectMapper, response, HttpStatus.FORBIDDEN, ErrorCode.ACCESS_DENIED);
return (request, response, exception) -> {
String errorId = UUID.randomUUID().toString();
log.warn(
"Access denied: errorId={}, method={}, path={}, exception={}",
errorId,
request.getMethod(),
request.getRequestURI(),
exception.getClass().getSimpleName());
writeProblemDetail(objectMapper, response, HttpStatus.FORBIDDEN, ErrorCode.ACCESS_DENIED, errorId);
};
}

private void writeProblemDetail(
ObjectMapper objectMapper,
jakarta.servlet.http.HttpServletResponse response,
HttpStatus status,
ErrorCode errorCode)
ErrorCode errorCode,
String errorId)
throws IOException {

ProblemDetail problemDetail = ProblemDetail.forStatusAndDetail(status, errorCode.getMessage());
problemDetail.setTitle(status.getReasonPhrase());
problemDetail.setType(URI.create("https://api.han-spoon.site/problems/" + errorCode.getCode()));
problemDetail.setProperty("code", errorCode.getCode());
problemDetail.setProperty("timestamp", OffsetDateTime.now());
problemDetail.setProperty("errorId", errorId);

response.setStatus(status.value());
response.setContentType(MediaType.APPLICATION_PROBLEM_JSON_VALUE);
objectMapper.writeValue(response.getOutputStream(), problemDetail);
}

private String rootCauseName(Throwable throwable) {
Throwable current = throwable;
while (current.getCause() != null && current.getCause() != current) {
current = current.getCause();
}
return current.getClass().getSimpleName();
}
}
6 changes: 4 additions & 2 deletions ...est/java/com/hanspoon/backend_api/global/config/SecurityErrorResponseIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ void missingTokenReturnsProblemDetail() throws Exception {
mockMvc.perform(get(PROTECTED_ENDPOINT))
.andExpect(status().isUnauthorized())
.andExpect(content().contentTypeCompatibleWith(MediaType.APPLICATION_PROBLEM_JSON))
.andExpect(jsonPath("$.code").value("INVALID_TOKEN"));
.andExpect(jsonPath("$.code").value("INVALID_TOKEN"))
.andExpect(jsonPath("$.errorId").isNotEmpty());
}

@Test
Expand All @@ -45,6 +46,7 @@ void invalidTokenReturnsProblemDetailNotEmptyBody() throws Exception {
mockMvc.perform(get(PROTECTED_ENDPOINT).header(HttpHeaders.AUTHORIZATION, "Bearer not-a-jwt"))
.andExpect(status().isUnauthorized())
.andExpect(content().contentTypeCompatibleWith(MediaType.APPLICATION_PROBLEM_JSON))
.andExpect(jsonPath("$.code").value("INVALID_TOKEN"));
.andExpect(jsonPath("$.code").value("INVALID_TOKEN"))
.andExpect(jsonPath("$.errorId").isNotEmpty());
}
}
Loading