Skip to content

Fix the ktlint failures already present on develop - #3111

Draft
StylianosGakis wants to merge 1 commit into
developfrom
chore/fix-ktlint-formatting
Draft

Fix the ktlint failures already present on develop#3111
StylianosGakis wants to merge 1 commit into
developfrom
chore/fix-ktlint-formatting

Conversation

@StylianosGakis

@StylianosGakis StylianosGakis commented Aug 28, 2026

Copy link
Copy Markdown
Member

Standalone fix, based directly on develop. Not part of stack #3112.

Why

./gradlew lintKotlin (the same task graph as ktlintCheck) already fails on develop, in two modules, unrelated to any other in-flight work. I confirmed it with a control run against a clean tree: identical failures either way.

Left alone it is a trap. Any PR that touches ktlint config, such as #3108, looks like it broke CI when it didn't.

What changed

YourInfoTab.kt is a plain ./gradlew :feature-insurances:formatKotlin run. Ignoring whitespace it comes to five lines: one HedvigText(...) call wrapped with a trailing comma, and one function signature collapsed onto a single line. No behaviour change.

-              HedvigText(it,
-                color = HedvigTheme.colorScheme.textSecondary)
+              HedvigText(
+                it,
+                color = HedvigTheme.colorScheme.textSecondary,
+              )

-internal fun ContractOwnerSection(
-  coInsuredList: List<CoInsured>,
-  modifier: Modifier,
-) {
+internal fun ContractOwnerSection(coInsuredList: List<CoInsured>, modifier: Modifier) {

TerminationRedirectionDestination.kt needed a manual fix, since standard:max-line-length is not auto-fixable. The same 127 character description string appears in two previews and is now split across two literals.

Verification

  • Repo-wide ./gradlew lintKotlin on this branch, rebased onto the current develop: BUILD SUCCESSFUL, no errors in any module or source set.
  • :feature-insurances:compileReleaseKotlin and :feature-terminate-insurance:compileReleaseKotlin both succeed.

Merging this first turns CI green for stack #3112, whose branches predate this fix.

`./gradlew lintKotlin` fails on develop in two modules, unrelated to any
in-flight work. Left alone it makes every PR that touches ktlint config
look like it broke CI.

YourInfoTab.kt is a plain `formatKotlin` run: argument wrapping, a
trailing comma, and a function signature that fits on one line. No
behaviour change.

TerminationRedirectionDestination.kt needed a hand, since max-line-length
is not auto-fixable. The same 127 character preview description appears in
two previews and is now split across two literals.
@StylianosGakis
StylianosGakis force-pushed the chore/fix-ktlint-formatting branch from 0a70e05 to dbc532e Compare August 28, 2026 20:55
@StylianosGakis
StylianosGakis changed the base branch from chore/namespace-import-ktlint-rule to develop August 28, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant