Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA
📝 작업 내용
📌 요약
AppointmentRouteViewController)으로 연결되던 상황LocationPreviewViewController)을 새로 만들어,내 위치 공유 / 상대 위치 공유 / 특정 장소 공유 버블이 각자의 좌표로 이 화면을 열도록 연결
MockLocationRepository제거🔍 상세
[1] LocationPreviewViewController 신규 구현
LocationPreviewMapViewNMFNaverMapView상속AppointmentRouteMapView와 동일하게 내 위치 버튼/줌 컨트롤을 켜고,MapMarker.Kind.place스타일로 좌표에 마커를 고정LocationPreviewViewController[2] 채팅 버블 → LocationPreviewViewController 연결
ChatBubbleBase.onMapTap클로저를(Coordinate) -> Void에서(String, String?, Coordinate) -> Void(title, subtitle, 좌표)로 확장locationShare(위치 공유): title=발신자 닉네임, subtitle="위치"placeShare(장소 공유): title=장소명, subtitle=주소ChatCoordinator에showLocationPreview(title:subtitle:coordinate:)추가,ChatViewController가 버블 탭 시 이걸 호출하도록 변경[3] 정리
MockLocationRepository삭제💬 리뷰 노트
Xcode > Device > Location을 None이 아닌 다른 값으로 설정해두어야
파란 점과 카메라 이동을 확인할 수 있습니다.
📸 영상 / 이미지
build.mp4