Repository navigation
Conversation
The login form's next field was returned verbatim by _post_login_destination, so POST /login {next: https://evil.example/steal} answered 302 Location: https://evil.example/steal (CWE-601). The value now goes through the existing _safe_redirect_url allowlist sanitiser before the role-landing checks: only ALLOWED_REDIRECT_PATHS survive (query strings preserved) and anything else collapses to / and falls through to the normal landing.
New tests/test_auth.py::TestPostLoginRedirect (9 tests) pins https://, http://, //, /\\, \\\\ and javascript: nexts to /, keeps /students?roster=abc&q=alice intact, and checks the live form POST. Suite: 743 passed / 10 skipped (was 734/10).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Login "next was used as the redirect target as is, so a crafted link could send users to an outside site. It now accepts only internal paths