Skip to content

Litext: exclude AppKit menu trampoline from Mac Catalyst - #14

Merged
gtokman merged 1 commit into
mainfrom
devin/1787025134-catalyst-nsmenu
Aug 18, 2026
Merged

Litext: exclude AppKit menu trampoline from Mac Catalyst#14
gtokman merged 1 commit into
mainfrom
devin/1787025134-catalyst-nsmenu

Conversation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

Summary

NSMenuItemActionTrampoline.swift is the only file in the package gated on bare #if canImport(AppKit). Under Mac Catalyst that check is true (AppKit is importable) while NSMenu/NSMenuItem/NSImage are marked unavailable, so any Catalyst target linking MarkdownView fails to compile:

'NSMenu' is unavailable in Mac Catalyst

Every other platform fork in the package is written #if canImport(UIKit) … #elseif canImport(AppKit), which already resolves to the UIKit branch on Catalyst. This aligns the one outlier:

-#if canImport(AppKit)
+#if canImport(AppKit) && !targetEnvironment(macCatalyst)

No behavior change on macOS/iOS; the trampoline is only referenced from AppKit menu code.

Link to Devin session: https://app.devin.ai/sessions/ffcab2338e3d4dbdb02ec0a942f711e9
Requested by: @gtokman

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@gtokman gtokman self-assigned this Aug 18, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@vercel

vercel Bot commented Aug 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
markdown-view Ready Ready Preview, v0 Aug 18, 2026 3:52am

Request Review

@gtokman
gtokman merged commit 2219c3f into main Aug 18, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant