Skip to content

fix order of tabs and add nature to crossmatch page #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kraysent merged 1 commit into from
Aug 16, 2026
Merged

fix order of tabs and add nature to crossmatch page #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/admin/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,15 +95,15 @@ function Layout() {
>
{loggedIn ? (
<>
<NavItem to="/" end label="Admin">
<MdAdminPanelSettings size={20} />
</NavItem>
<NavItem to="/tables" label="Tables">
<MdTableChart size={20} />
</NavItem>
<NavItem to="/data-catalog" label="Data catalog">
<MdAccountTree size={20} />
</NavItem>
<NavItem to="/" end label="Admin">
<MdAdminPanelSettings size={20} />
</NavItem>
</>
) : null}
</NavRail>
Expand Down
13 changes: 13 additions & 0 deletions apps/admin/src/components/ui/ObjectSummary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ type ObjectSummaryCatalogs = {
z: number;
e_z: number;
} | null;
nature?: {
type_name: string;
} | null;
};

export function ObjectSummary({
Expand All @@ -34,6 +37,7 @@ export function ObjectSummary({
}): ReactElement {
const equatorial = catalogs?.coordinates?.equatorial;
const redshift = catalogs?.redshift;
const nature = catalogs?.nature;
const raUnit = schema.units.coordinates?.equatorial?.ra || "deg";
const eRaUnit = schema.units.coordinates?.equatorial?.e_ra || raUnit;
const eDecUnit = schema.units.coordinates?.equatorial?.e_dec || raUnit;
Expand All @@ -45,6 +49,13 @@ export function ObjectSummary({
</>
);

const natureField = nature?.type_name ? (
<>
<dt className="text-muted">Nature</dt>
<dd>{nature.type_name}</dd>
</>
) : null;

const raField = equatorial ? (
<>
<dt className="text-muted">RA</dt>
Expand Down Expand Up @@ -82,6 +93,7 @@ export function ObjectSummary({
return (
<dl className="flex flex-wrap items-start gap-x-6 gap-y-1 text-sm">
<div className="min-w-0">{nameField}</div>
{natureField && <div className="min-w-0">{natureField}</div>}
{raField && <div className="min-w-0">{raField}</div>}
{decField && <div className="min-w-0">{decField}</div>}
{redshiftField && <div className="min-w-0">{redshiftField}</div>}
Expand All @@ -92,6 +104,7 @@ export function ObjectSummary({
return (
<dl className="grid grid-cols-[auto_1fr] gap-x-4 gap-y-1 text-sm">
{nameField}
{natureField}
{raField}
{decField}
{redshiftField}
Expand Down
Loading