Skip to content

refactor(per): consolidate PER dashboard data endpoints - #2821

Merged
szabozoltan69 merged 2 commits into
developfrom
feature/per-dashboard-api-contract
Sep 3, 2026
Merged

refactor(per): consolidate PER dashboard data endpoints#2821
szabozoltan69 merged 2 commits into
developfrom
feature/per-dashboard-api-contract

Conversation

@arunissun

Copy link
Copy Markdown
Contributor

Summary

  • Consolidate the PER map and dashboard data query/serialization logic.
  • Return stable latest-country map results while retaining complete PER process history.
  • Add read-only response caching and bounded-query coverage for both endpoints.
  • Add focused regression tests for response behavior, ordering, cache use, and realistic related data.

Validation

  • Black, isort, and Flake8 passed.
  • Django migration check passed with no changes detected.
  • Focused PER endpoint tests: 9 passed.
  • OpenAPI schema matches the committed artifact.
  • Full API suite: 324 passed, 4 skipped.

Scope

No migrations, route changes, frontend changes, or unrelated cleanup.

@szabozoltan69

Copy link
Copy Markdown
Contributor

Hi @arunissun – it seems to be some redundancy in this change.
E.g. the AREA_NAMES and the AFFIRMATIVE_WORDS are also in per/drf_views.py, and you re-define them in per/dashboard_data.py.
Could you please refactor your code so that such duplications should not be there?

@arunissun

Copy link
Copy Markdown
Contributor Author

@szabozoltan69 I WILL do that thanks for the review

@szabozoltan69
szabozoltan69 merged commit 90c79e7 into develop Sep 3, 2026
3 checks passed
@szabozoltan69
szabozoltan69 deleted the feature/per-dashboard-api-contract branch September 3, 2026 10:22
@szabozoltan69

Copy link
Copy Markdown
Contributor

Deployed to Staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants