Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Runner Job admission for Node
project_buildso a build planned from a Project's declared npm, pnpm, yarn, or bun manager is admitted under the same canonical process/digest contract as the typed Build Plan.ProjectBuildPlan::is_valid()at the Runner Job admission boundary, aligning it with Core wire validation and the Runner-owned planner.adapter=nodeandadapter=auto, including typed wire decode, Job queue admission, and a manager substitution with a recomputed digest rejected by the source fence.The previous admission validator rebuilt the canonical command with an npm-defaulting helper. A valid pnpm/yarn/bun plan thus passed Runner planning and Core validation but was rejected before Job enqueue. The Runner's current Project recipe remains authoritative for manager selection.
Verification
main@7b35aafb): The new regression fails onpnpm/Node: Runner rejected its own canonical Node build plan.ed5afe29): The identical regression passes, including all eight manager/adapter combinations.project_buildsuite: 25 passed, 0 failed, 1 ignored (real Node/npm fixture).cargo fmt --all -- --checkandgit diff --checkpassed.ed5afe29eaa2c86e11aaa3b906cb6d3b0959a2f2: Success — 13 jobs passed, 0 failed, 5 correctly skipped by path-based selection (run 39567710526). Linux Runner/Server/workspace, Windows Runner, macOS Core, Contracts, MCP conformance, and the CItestgate passed.Scope
Only the Runner admission check and its adjacent regression tests change (2 files). No new model-facing tool, schema/capability, executable-selection rule, process fallback, or persistence/retry contract. This follows the existing project-operation lifecycle tracked in #962.