Add fmt 12.2.0 compatibility - #1551
Merged
Merged
Conversation
johnhaddon
reviewed
Aug 18, 2026
johnhaddon
left a comment
johnhaddon
left a comment
Member
There was a problem hiding this comment.
LGTM, but I made one small suggestion that might make things a tiny bit tidier...
Member
|
After merging #1552, I had a go at building with |
With the addition of the `format_as` overloads in the previous commit, we no longer hit deprecated code in `fmt` and can remove this workaround.
Collaborator
Author
Yeah, I think platform 26 will be the moment for a LibFormat bump. I haven't investigated the Gaffer side of the update, but this gets us in a place to begin... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows Cortex to build with modern versions of
libfmtwhile maintaining compatibility with our current version of 9.1.0. As a result we can remove theFMT_DEPRECATEDworkaround recently added for Xcode 16, as theformat_as()overloads in this PR mean that we're no longer hitting deprecated functionality inlibfmt9.1.0.