Conversation
NgLoader
reviewed
Sep 18, 2026
| org.gradle.configuration-cache=false | ||
| org.gradle.vfs.watch=false | ||
| org.gradle.jvmargs=-Xmx4G -Dfile.encoding=UTF-8 | ||
| org.gradle.java.installations.fromEnv=JAVA_HOME_17_X64,JAVA_HOME_21_X64,JAVA_HOME_25_X64 |
Member
There was a problem hiding this comment.
Do we need to document this for new contributors?
| private static final Logger LOGGER = LoggerFactory.getLogger(FabricLoggerAccessor.class); | ||
|
|
||
| @Override | ||
| public void log(@NotNull LogLevel level, @NotNull String message, @Nullable Throwable throwable) { |
Member
There was a problem hiding this comment.
Use INFO as fallback logging instead of printing nothing if a new logging format is added.
| protected ServerLevel level; | ||
|
|
||
| @Definition(id = "action", local = @Local(type = Action.class)) | ||
| @Definition(id = "START_DESTROY_BLOCK", |
Member
There was a problem hiding this comment.
Is this a safe call?
Is it possible to fake it (by sending invalid packets) or can it be triggered by punching blocks to cause updates even if you cancel it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add experimental support for Fabric.
How Has This Been Tested?
Not tested yet
Types of Changes