Skip to content

[tooling] Verify the generated changelog workflows end to end (follow-up to #300) #302

Closed

Description

@jesusmpc

Follow-up to #300. These checks need a real PR or release, so they could not be done while implementing the change.

  • Changelog / Closing issue (code-changelog-check.yml) runs on a test PR: report in the job summary, warning when the PR closes no issue, and no warning for skip-release.
  • The same check on a fork PR: read-only token is enough, and the job summary is the only feedback.
  • keep-a-changelog bump tolerates an empty [Unreleased] (fail-on-empty-release-notes: false), in both the release job and the release preview.
  • code-release_preview.yml generates [Unreleased] with --to HEAD^1 --include-pr N and the PR comment lists the expected entries.
  • .github/pull_request_template.md shows up on a new PR.
  • A real release run (workflow_dispatch ACTION=release or a merged release-type/* PR): the generate step writes [Unreleased], the bump and sanitize steps succeed, and the tag is created. A script error must fail the job before the tag.
  • The snapshot job is unchanged and still works.

Activity

  1. jesusmpc commented on Nov 11, 2026

    @jesusmpc
    ContributorAuthor

    Verified end to end:

    Not verified:

    • Fork PR with a read-only token (no fork available).
    • Snapshot job (unchanged, not exercised).

    Note for #303: GitHub updates a PR's closing-issue references a few seconds after the edited event, so a check run right after adding Closes #N can still report "not linked". Worth handling before CHANGELOG_LINK_ENFORCE is flipped to true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/internalInternal work; no changelog entry

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions