Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/code-changelog-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ env:
# 'true' fails a PR that has no linked issue and no bypass. 'false' only
# warns: flip it to 'true' in a follow-up PR once a release has run end to
# end with the generated changelog.
CHANGELOG_LINK_ENFORCE: "false"
CHANGELOG_LINK_ENFORCE: "true"

jobs:
closing-issue:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docs/code-changelog-check.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Any pull request to `main` or `main-*` that is `opened`, `synchronize`d, `reopen
- A maintainer can waive the rule with the `skip-release` label, which also skips the release on merge. The issues such a PR does close still get entries in the next release.
- Dependabot PRs are exempt.
- Issues labelled `kind/internal` or `kind/epic`, even together with a `kind/*` category, count as a link but get no entry, and an issue already listed in an earlier release is not listed again. Both are shown in the report. `skip-changelog` has no effect.
- The check is warn-only for now: `CHANGELOG_LINK_ENFORCE` is `'false'`. Setting it to `'true'` (a follow-up PR, once a release has run end to end) makes a PR with no linked issue and no bypass fail.
- The check is enforcing: `CHANGELOG_LINK_ENFORCE` is `'true'`, so a PR with no linked issue and no bypass fails. Set it back to `'false'` to make it warn-only.

## Jobs

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@

## 4. End-to-end verification and rollout (tracked in #302 and #303)

- [ ] 4.1 Verify the check, the release preview comment, the empty-`[Unreleased]` bump and a real release run (InditexTech/docouture#302)
- [ ] 4.2 Add the check to branch protection, retire the `skip-changelog` label, update the `skip-release` label description, and flip `CHANGELOG_LINK_ENFORCE` after one release (InditexTech/docouture#303)
- [x] 4.1 Verify the check, the release preview comment, the empty-`[Unreleased]` bump and a real release run (InditexTech/docouture#302)
- [x] 4.2 Add the check to branch protection, retire the `skip-changelog` label, update the `skip-release` label description, and flip `CHANGELOG_LINK_ENFORCE` after one release (InditexTech/docouture#303)
Loading