Repository navigation
Restore knowledge intake capacity with owner topic pages - #133
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0876ad3341
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 只有 `DIFF-数字字母` 是可审计规则 ID。模型专有常量和已验证偏差留在对应 | ||
| [模型 owner](../../models/_index.md)；本页只承载多个 diffusion 模型共用的不变量。 | ||
|
|
||
| 相关专题：[Diffusion 平台 kernel 与设备合同](rules-platform-kernels.md)（`DIFF-1t`, `DIFF-1u`, `DIFF-1v`, `DIFF-1w`）。 |
There was a problem hiding this comment.
When later PR evidence overlaps any of the eight moved rules, automated intake cannot union it with the existing conclusion: KnowledgeCurator.catalog() enumerates only files named rules.md, while duplicate detection checks only the selected target page, so neither new rules-*.md file is selectable or searched. This can append synonymous or duplicate rules back into the parent pages, defeating the stated capacity fix; either retain these definitions in rules.md or extend the curator's catalog and owner-wide deduplication contract to split rule pages.
AGENTS.md reference: AGENTS.md:L12-L17
Useful? React with 👍 / 👎.
|
|
||
| 只有 `MCPMO-数字字母` 是可审计规则 ID。 | ||
|
|
||
| 相关专题：[MiniCPM-o 4.5 Code2Wav 运行时合同](rules-code2wav-runtime.md)（`MCPMO-1f`, `MCPMO-1g`, `MCPMO-1h`, `MCPMO-1i`）。 |
There was a problem hiding this comment.
For Direct reviews of Code2Wav NPUGraph, Dynamo, windowing, or encoder-less Flow changes, this link is never delivered to the reviewer: _direct_quick_map() starts at the following ## Direct heading and stops at the next level-two heading, so the pre-heading link and all moved rule bodies are excluded while the embedded map still reports ok. The diffusion split has the same defect for DIFF-1t–DIFF-1w; add the topic links and matching signals within each Direct section so these contracts remain reachable without violating the full-page reading budget.
AGENTS.md reference: knowledge/AGENTS.md:L16-L16
Useful? React with 👍 / 👎.
Automatic knowledge batches could only append to each owner's rules.md entry page, and several of those pages sit within a few hundred bytes of the tree validator's 32 KiB split gate. Every rule routed there failed validation after apply, rolled the whole batch back, and needed a human to split the page by hand (#133, #134). The catalog now lists every owner rule page: the rules.md entry page and the owner's type: rule rules-<topic>.md topic pages the tree already uses. catalog_entries() carries each page's remaining bytes and non-empty lines, mirrored from check_knowledge_tree.py, the prompt shows that room, and validate_proposals rejects a proposal that would not fit ("page full") before anything is written, consuming room across one batch so two rules aimed at one page cannot both pass. Knowledge API 1.0.0 -> 1.1.0, backward compatible. The knowledge contract sentence that named rules.md as the only PR learning target now names the owner's rule pages; SPEC/sdk.md and SPEC/contract.md record the new surface and version. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Js5CsiwSYjcAYvqti1Lp1Y
Automatic knowledge intake exhausted validation repairs because the MiniCPM entry page had only 101 bytes free and the diffusion entry page was also close to 32 KiB. Move eight existing rules unchanged into owner-local Code2Wav runtime and diffusion platform-kernel pages, and link them from the entry pages and indexes. This restores room for new proposals without dropping rules or relaxing validation.
Validation: both knowledge validators pass; release audit passes in enforce mode against the recorded baseline; moved rule bodies and citations are preserved verbatim.